Project Tree improvements

If there is something important you think is missing in the current version of ZGameEditor then you can post a feature request here!

Moderator: Moderators

User avatar
rrTea
Posts: 378
Joined: Sat Feb 15, 2014 9:54 am

Project Tree improvements

Post by rrTea » Sun Sep 07, 2014 4:15 am

It would probably be easier to read if the comments in the Project Tree were a bit lighter. Also if the type and the name were swapped, it'd reduce the "stairs" effect that one bumps into when going through the list. I'm attaching an example.

Edit: cropped the image
Attachments
剪贴板图片 (1).png
剪贴板图片 (1).png (51.92 KiB) Viewed 7060 times
Last edited by rrTea on Mon Apr 18, 2016 7:19 am, edited 4 times in total.

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Sun Sep 07, 2014 5:39 pm

Seems like a good idea. I'm going to implement this unless someone has good arguments against it.

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Mon Sep 08, 2014 11:49 am

Turned out that I've tried to do this before (painting comments in gray) but the built in Treeview in Delphi makes it difficult. And I don't want to change to a 3rd party treeview component just for this. I'll have to put it on hold until I can find a solution.

User avatar
jph_wacheski
Posts: 1005
Joined: Sat Feb 16, 2008 8:10 pm
Location: Canada
Contact:

Post by jph_wacheski » Mon Sep 08, 2014 12:15 pm

implementation aside, looks like a good readability improvement,. .
iterationGAMES.com

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Wed Sep 10, 2014 8:16 am

I've made an attempt of fixing this now. You can try it here:

http://www.zgameeditor.org/files/ZGameEditor_beta.zip

It is only the comments that are gray, I haven't switched name/types because some components show a property value as part of the caption. I.e. "PlaySound Sound1" could either mean "play sound1" or "a PlaySound component named Sound1". If the name comes first there is no such ambiguity.

User avatar
Rado1
Posts: 771
Joined: Wed May 05, 2010 12:16 pm

Post by Rado1 » Wed Sep 10, 2014 7:49 pm

I do not like the latest change too much because comments become gray and are worse to read. I use comments very frequently to keep order in larger projects, so they are important. Instead of gray I would suggest to use another color, but should be sufficiently visible (in all themes).

User avatar
rrTea
Posts: 378
Joined: Sat Feb 15, 2014 9:54 am

Post by rrTea » Thu Sep 11, 2014 2:56 am

Rado1 is right, in its current implementation the readability is a problem.

I think adding another color would end up messy because the icons in the project tree are pretty colorful already.

It seems to me that the problem is not using gray (gray per se is not an instant readability killer as long as the contrast is high enough, speaking as a designer) but rather something else: the comments are a bit too close in brightness / tone to the rest of the text. …in fact I went and checked it and the rest of the text is off, not the comments! For some reason they are not black but dark grey. See for yourself.
Attachments
剪贴板图片 (5).png
剪贴板图片 (5).png (5.37 KiB) Viewed 7064 times

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Thu Sep 11, 2014 7:52 am

Here the text definitely is RGB 0,0,0. I checked in a paint program. This is with default "Windows" style selected in ZGE. Are you sure you didn't check a pixel at the edges of the text? They could be antialised at the edges.

If we pick another color for the comments it has to be one that works with other styles too (with "Golden graphite" background is black etc).

I've used system color clGrayText now which is supposed to change with styles but I notice in golden graphite it takes the same color as the other text.

User avatar
rrTea
Posts: 378
Joined: Sat Feb 15, 2014 9:54 am

Post by rrTea » Thu Sep 11, 2014 8:05 am

Oh that's right, I'm using a theme (Turquoise Gray). Yes I'm pretty sure I didn't check a pixel at the edges since I'm not using AAed text. I didn't know themes can change even the color of the text in the Project Tree.

This particular theme works really well for me (I prefer the text to be slightly lighter, just so the contrast is not too stark) but I'll probably tweak it a bit if the new rendering of comments ends up approved.

User avatar
Rado1
Posts: 771
Joined: Wed May 05, 2010 12:16 pm

Post by Rado1 » Thu Sep 11, 2014 10:07 am

Some styles look good (e.g. Carbon), but the Windows style is not very good if the Windows Classic theme is used, see the screenshot.
Attachments
scr.jpg
Project tree in Windows Classic
scr.jpg (47.26 KiB) Viewed 7038 times

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Thu Sep 11, 2014 11:36 am

Change color "clInactiveCaptionText" which seems to offer better contrast in most styles. Please download and check it out.

http://www.zgameeditor.org/files/ZGameEditor_beta.zip

User avatar
Rado1
Posts: 771
Joined: Wed May 05, 2010 12:16 pm

Post by Rado1 » Thu Sep 11, 2014 11:50 am

Hi Ville, the current version is even worse that the previous one on windows Classic; see the screenshot.
Attachments
scr.jpg
Project tree in Windows Classic
scr.jpg (48.84 KiB) Viewed 7030 times

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Thu Sep 11, 2014 12:03 pm

Strange, here it looks like this:
Attachments
commentcolors.png
commentcolors.png (40.21 KiB) Viewed 7027 times

User avatar
Rado1
Posts: 771
Joined: Wed May 05, 2010 12:16 pm

Post by Rado1 » Thu Sep 11, 2014 12:05 pm

But I use Windows Classic (similar to Windows 98 ) theme and you are using one of the Aero themes.

User avatar
VilleK
Site Admin
Posts: 2025
Joined: Mon Jan 15, 2007 4:50 pm
Location: Stockholm, Sweden
Contact:

Post by VilleK » Fri Sep 12, 2014 9:35 am

So final color is dependent on both Window style and Delphi style. Tricky to get something that will always guarantee good contrast then.

I've made another attempt. Please download and try again.

Post Reply